This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(abigen): safe ident underscore followed by numeric #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/fix-underscore-numeric
branch
from
ae4695a
to
6200358
Compare
gakonst
approved these changes
Feb 27, 2022
|
|
||
| let provider = Arc::new(Provider::new(MockProvider::new())); | ||
| let contract = Test::new(Address::default(), Arc::clone(&provider)); | ||
| // NOTE: this seems to be weird behaviour of `Inflector::to_snake_case` which turns "100pct" -> |
There was a problem hiding this comment.
Should we fix this upstream? Is it right behavior?
|
Merged to unblock the compilation in the linked issue, but maybe we should fix inflector too? |
|
+1 on fixing this upstream, will look into the root cause. |
| let contract = Test::new(Address::default(), Arc::clone(&provider)); | ||
| // NOTE: this seems to be weird behaviour of `Inflector::to_snake_case` which turns "100pct" -> | ||
| // "10_0pct" | ||
| let _call = contract._10_0pct("hello".to_string()); |
There was a problem hiding this comment.
Do we know why it becomes 10_0pct and not 100_pct? @mattsse
There was a problem hiding this comment.
Check the comment right above this code line! It's an issue in the Inflector crate, which we'll track and solve separately
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #967
Solution
check if identifiers are valid and prefix with an underscore if they start with a numeric value
PR Checklist